[6.2][concurrency] Implement protocol witness thunking in SILGen for @execution(caller)/@execution(concurrent).#80748
Merged
gottesmm merged 1 commit intoswiftlang:release/6.2from Apr 16, 2025
Conversation
…ution(caller)/@execution(concurrent). This involved cleaning up and generalizing the work from f245389. I followed the same approach: hide the implicit parameter while we run things through translateArgument and friends and then put it back in manually. As an additional benefit, I think I found a good place to put FunctionIsolation onto lowered AnyFunctionTypes that will not cause cycles in the evaluator since it is done in TypeLowering. rdar://148785846 (cherry picked from commit 04b845c)
Contributor
Author
|
@swift-ci test |
gottesmm
changed the title
rjmccall
approved these changes
Apr 10, 2025
Contributor
rjmccall
left a comment
rjmccall
left a comment
There was a problem hiding this comment.
I like how this works out, thanks!
hborla
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: This involved cleaning up and generalizing the work from f245389. I followed the same approach: hide the implicit parameter while we run things through translateArgument and friends and then put it back in manually.
Scope: Affects pattern matching
Issue: rdar://148785846
Original PR: #80622
Risk: Low. Very targeted tweak to protocol witness thunking. We avoided changing the large machinery that is used for processing generalized parameters and instead did manual adjustment to insert/remove the value as appropriate.
Testing: Added tests to test suite
Reviewer: @xedin @rjmccall